Skip to content

Commit e4ca3fa

Browse files
committed
cmd/dist: test cgo internal linking on darwin-arm64
CL 383554 disables testing cgo internal linking on all ARM64 but Windows, because it doesn't work with newer GCC. But - darwin-arm64 works, and it does not use GCC - we don't support cgo internal linking on windows-arm64 anyway. This CL fixes the condition. Change-Id: I9eb7b81ef75e482f5e95d2edae4863ba21396432 Reviewed-on: https://go-review.googlesource.com/c/go/+/384269 Trust: Cherry Mui <[email protected]> Run-TryBot: Cherry Mui <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent 6749dd4 commit e4ca3fa

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/cmd/dist/test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1119,7 +1119,7 @@ func (t *tester) cgoTest(dt *distTest) error {
11191119

11201120
// Skip internal linking cases on arm64 to support GCC-9.4 and above.
11211121
// See issue #39466.
1122-
skipInternalLink := goarch == "arm64" && goos != "windows"
1122+
skipInternalLink := goarch == "arm64" && goos != "darwin"
11231123

11241124
if t.internalLink() && !skipInternalLink {
11251125
cmd := t.addCmd(dt, "misc/cgo/test", t.goTest(), "-tags=internal")

0 commit comments

Comments
 (0)