cmd/link: don't cast end address to int32

cherrymui · cherrymui · commit af0f8c149e8a · 2021-05-12T15:04:42.000Z
When linking a very large binary, the section address may not fit in int32. Don't truncate it. Change-Id: Ibcc8d74bf5662611949e547ce44ca8b973de383f Reviewed-on: https://go-review.googlesource.com/c/go/+/319289 Trust: Cherry Mui <cherryyz@google.com> Run-TryBot: Cherry Mui <cherryyz@google.com> Reviewed-by: Than McIntosh <thanm@google.com> TryBot-Result: Go Bot <gobot@golang.org>
diff --git a/src/cmd/link/internal/ld/elf.go b/src/cmd/link/internal/ld/elf.go
@@ -1171,7 +1171,7 @@ func elfrelocsect(ctxt *Link, out *OutBuf, sect *sym.Section, syms []loader.Sym)
 		}
 	}
 
-	eaddr := int32(sect.Vaddr + sect.Length)
+	eaddr := sect.Vaddr + sect.Length
 	for _, s := range syms {
 		if !ldr.AttrReachable(s) {
 			continue
diff --git a/src/cmd/link/internal/ld/macho.go b/src/cmd/link/internal/ld/macho.go
@@ -1194,7 +1194,7 @@ func machorelocsect(ctxt *Link, out *OutBuf, sect *sym.Section, syms []loader.Sy
 		}
 	}
 
-	eaddr := int32(sect.Vaddr + sect.Length)
+	eaddr := sect.Vaddr + sect.Length
 	for _, s := range syms {
 		if !ldr.AttrReachable(s) {
 			continue

Original file line number	Diff line number	Diff line change
`@@ -1171,7 +1171,7 @@ func elfrelocsect(ctxt Link, out OutBuf, sect *sym.Section, syms []loader.Sym)`
`1171`	`1171`	`}`
`1172`	`1172`	`}`
`1173`	`1173`
`1174`		`- eaddr := int32(sect.Vaddr + sect.Length)`
	`1174`	`+ eaddr := sect.Vaddr + sect.Length`
`1175`	`1175`	`for _, s := range syms {`
`1176`	`1176`	`if !ldr.AttrReachable(s) {`
`1177`	`1177`	`continue`
Original file line number	Diff line number	Diff line change
`@@ -1194,7 +1194,7 @@ func machorelocsect(ctxt Link, out OutBuf, sect *sym.Section, syms []loader.Sy`
`1194`	`1194`	`}`
`1195`	`1195`	`}`
`1196`	`1196`
`1197`		`- eaddr := int32(sect.Vaddr + sect.Length)`
	`1197`	`+ eaddr := sect.Vaddr + sect.Length`
`1198`	`1198`	`for _, s := range syms {`
`1199`	`1199`	`if !ldr.AttrReachable(s) {`
`1200`	`1200`	`continue`