net: tolerate permission errors in interface tests

heschi · gopherbot · commit 8e1ec1cb9385 · 2023-07-18T23:51:35.000Z
On our linux-arm64 builders, we're getting permission errors despite running as root. Detect those errors and skip the test. For #61414. Change-Id: I5d7c45789337bee3860b19335bbb9eb884c48986 Reviewed-on: https://go-review.googlesource.com/c/go/+/510737 Auto-Submit: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
diff --git a/src/net/interface_unix_test.go b/src/net/interface_unix_test.go
@@ -193,6 +193,9 @@ func TestInterfaceArrivalAndDepartureZoneCache(t *testing.T) {
 		t.Skipf("test requires external command: %v", err)
 	}
 	if err := ti.setup(); err != nil {
+		if e := err.Error(); strings.Contains(e, "Permission denied") {
+			t.Skipf("permission denied, skipping test: %v", e)
+		}
 		t.Fatal(err)
 	}
 	defer ti.teardown()

Original file line number	Diff line number	Diff line change
`@@ -193,6 +193,9 @@ func TestInterfaceArrivalAndDepartureZoneCache(t *testing.T) {`
`193`	`193`	`t.Skipf("test requires external command: %v", err)`
`194`	`194`	`}`
`195`	`195`	`if err := ti.setup(); err != nil {`
	`196`	`+ if e := err.Error(); strings.Contains(e, "Permission denied") {`
	`197`	`+ t.Skipf("permission denied, skipping test: %v", e)`
	`198`	`+ }`
`196`	`199`	`t.Fatal(err)`
`197`	`200`	`}`
`198`	`201`	`defer ti.teardown()`