slices: explicitly discard results of some functions

adonovan · adonovan · commit 8088b6db2341 · 2024-01-05T21:35:07.000Z
This will otherwise trigger an "unusedresult" vet check. Fixes #64978 Change-Id: Ie19aded0f808d394f389452c3ff7f3edc1ed710d Reviewed-on: https://go-review.googlesource.com/c/go/+/554196 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Bryan Mills <bcmills@google.com>
diff --git a/src/slices/slices_test.go b/src/slices/slices_test.go
@@ -557,7 +557,7 @@ func TestInsertPanics(t *testing.T) {
 		{"with out-of-bounds index and = cap", a[:1:2], 2, b[:]},
 		{"with out-of-bounds index and < cap", a[:1:3], 2, b[:]},
 	} {
-		if !panics(func() { Insert(test.s, test.i, test.v...) }) {
+		if !panics(func() { _ = Insert(test.s, test.i, test.v...) }) {
 			t.Errorf("Insert %s: got no panic, want panic", test.name)
 		}
 	}
@@ -684,7 +684,7 @@ func TestDeletePanics(t *testing.T) {
 		{"s[i:j] is valid and j > len(s)", s, 0, 4},
 		{"s[i:j] is valid and i == j > len(s)", s, 3, 3},
 	} {
-		if !panics(func() { Delete(test.s, test.i, test.j) }) {
+		if !panics(func() { _ = Delete(test.s, test.i, test.j) }) {
 			t.Errorf("Delete %s: got no panic, want panic", test.name)
 		}
 	}
@@ -906,10 +906,10 @@ func TestGrow(t *testing.T) {
 	}
 
 	// Test number of allocations.
-	if n := testing.AllocsPerRun(100, func() { Grow(s2, cap(s2)-len(s2)) }); n != 0 {
+	if n := testing.AllocsPerRun(100, func() { _ = Grow(s2, cap(s2)-len(s2)) }); n != 0 {
 		t.Errorf("Grow should not allocate when given sufficient capacity; allocated %v times", n)
 	}
-	if n := testing.AllocsPerRun(100, func() { Grow(s2, cap(s2)-len(s2)+1) }); n != 1 {
+	if n := testing.AllocsPerRun(100, func() { _ = Grow(s2, cap(s2)-len(s2)+1) }); n != 1 {
 		errorf := t.Errorf
 		if race.Enabled || testenv.OptimizationOff() {
 			errorf = t.Logf // this allocates multiple times in race detector mode
@@ -921,7 +921,7 @@ func TestGrow(t *testing.T) {
 	var gotPanic bool
 	func() {
 		defer func() { gotPanic = recover() != nil }()
-		Grow(s1, -1)
+		_ = Grow(s1, -1)
 	}()
 	if !gotPanic {
 		t.Errorf("Grow(-1) did not panic; expected a panic")
@@ -1037,7 +1037,7 @@ func TestReplacePanics(t *testing.T) {
 		{"s[i:j] is valid and j > len(s)", s, nil, 0, 4},
 	} {
 		ss, vv := Clone(test.s), Clone(test.v)
-		if !panics(func() { Replace(ss, test.i, test.j, vv...) }) {
+		if !panics(func() { _ = Replace(ss, test.i, test.j, vv...) }) {
 			t.Errorf("Replace %s: should have panicked", test.name)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -557,7 +557,7 @@ func TestInsertPanics(t *testing.T) {`
`557`	`557`	`{"with out-of-bounds index and = cap", a[:1:2], 2, b[:]},`
`558`	`558`	`{"with out-of-bounds index and < cap", a[:1:3], 2, b[:]},`
`559`	`559`	`} {`
`560`		`- if !panics(func() { Insert(test.s, test.i, test.v...) }) {`
	`560`	`+ if !panics(func() { _ = Insert(test.s, test.i, test.v...) }) {`
`561`	`561`	`t.Errorf("Insert %s: got no panic, want panic", test.name)`
`562`	`562`	`}`
`563`	`563`	`}`
`@@ -684,7 +684,7 @@ func TestDeletePanics(t *testing.T) {`
`684`	`684`	`{"s[i:j] is valid and j > len(s)", s, 0, 4},`
`685`	`685`	`{"s[i:j] is valid and i == j > len(s)", s, 3, 3},`
`686`	`686`	`} {`
`687`		`- if !panics(func() { Delete(test.s, test.i, test.j) }) {`
	`687`	`+ if !panics(func() { _ = Delete(test.s, test.i, test.j) }) {`
`688`	`688`	`t.Errorf("Delete %s: got no panic, want panic", test.name)`
`689`	`689`	`}`
`690`	`690`	`}`
`@@ -906,10 +906,10 @@ func TestGrow(t *testing.T) {`
`906`	`906`	`}`
`907`	`907`
`908`	`908`	`// Test number of allocations.`
`909`		`- if n := testing.AllocsPerRun(100, func() { Grow(s2, cap(s2)-len(s2)) }); n != 0 {`
	`909`	`+ if n := testing.AllocsPerRun(100, func() { _ = Grow(s2, cap(s2)-len(s2)) }); n != 0 {`
`910`	`910`	`t.Errorf("Grow should not allocate when given sufficient capacity; allocated %v times", n)`
`911`	`911`	`}`
`912`		`- if n := testing.AllocsPerRun(100, func() { Grow(s2, cap(s2)-len(s2)+1) }); n != 1 {`
	`912`	`+ if n := testing.AllocsPerRun(100, func() { _ = Grow(s2, cap(s2)-len(s2)+1) }); n != 1 {`
`913`	`913`	`errorf := t.Errorf`
`914`	`914`	`if race.Enabled \|\| testenv.OptimizationOff() {`
`915`	`915`	`errorf = t.Logf // this allocates multiple times in race detector mode`
`@@ -921,7 +921,7 @@ func TestGrow(t *testing.T) {`
`921`	`921`	`var gotPanic bool`
`922`	`922`	`func() {`
`923`	`923`	`defer func() { gotPanic = recover() != nil }()`
`924`		`- Grow(s1, -1)`
	`924`	`+ _ = Grow(s1, -1)`
`925`	`925`	`}()`
`926`	`926`	`if !gotPanic {`
`927`	`927`	`t.Errorf("Grow(-1) did not panic; expected a panic")`
`@@ -1037,7 +1037,7 @@ func TestReplacePanics(t *testing.T) {`
`1037`	`1037`	`{"s[i:j] is valid and j > len(s)", s, nil, 0, 4},`
`1038`	`1038`	`} {`
`1039`	`1039`	`ss, vv := Clone(test.s), Clone(test.v)`
`1040`		`- if !panics(func() { Replace(ss, test.i, test.j, vv...) }) {`
	`1040`	`+ if !panics(func() { _ = Replace(ss, test.i, test.j, vv...) }) {`
`1041`	`1041`	`t.Errorf("Replace %s: should have panicked", test.name)`
`1042`	`1042`	`}`
`1043`	`1043`	`}`