cmd/go,internal/platform: enable pie buildmode for windows/arm64

qmuntal · Bryan Mills · commit 3732a178061f · 2022-11-21T16:49:48.000Z
This CL adds windows/arm64 to the list of ports that supports PIE build mode. It is probably an oversight that this port is not marked as pie-capable because windows/arm64 only supports PIE build mode. Fixes #56872 Change-Id: I2bdd3ac207280f47ddcf8c2582f13025dafb9278 Reviewed-on: https://go-review.googlesource.com/c/go/+/452415 Run-TryBot: Cherry Mui <cherryyz@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go
@@ -2136,7 +2136,7 @@ func TestBuildmodePIE(t *testing.T) {
 	case "linux/386", "linux/amd64", "linux/arm", "linux/arm64", "linux/ppc64le", "linux/riscv64", "linux/s390x",
 		"android/amd64", "android/arm", "android/arm64", "android/386",
 		"freebsd/amd64",
-		"windows/386", "windows/amd64", "windows/arm":
+		"windows/386", "windows/amd64", "windows/arm", "windows/arm64":
 	case "darwin/amd64":
 	default:
 		t.Skipf("skipping test because buildmode=pie is not supported on %s", platform)
diff --git a/src/internal/platform/supported.go b/src/internal/platform/supported.go
@@ -129,7 +129,7 @@ func BuildModeSupported(compiler, buildmode, goos, goarch string) bool {
 			"darwin/amd64", "darwin/arm64",
 			"ios/amd64", "ios/arm64",
 			"aix/ppc64",
-			"windows/386", "windows/amd64", "windows/arm":
+			"windows/386", "windows/amd64", "windows/arm", "windows/arm64":
 			return true
 		}
 		return false

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ func BuildModeSupported(compiler, buildmode, goos, goarch string) bool {`
`129`	`129`	`"darwin/amd64", "darwin/arm64",`
`130`	`130`	`"ios/amd64", "ios/arm64",`
`131`	`131`	`"aix/ppc64",`
`132`		`- "windows/386", "windows/amd64", "windows/arm":`
	`132`	`+ "windows/386", "windows/amd64", "windows/arm", "windows/arm64":`
`133`	`133`	`return true`
`134`	`134`	`}`
`135`	`135`	`return false`