cmd/compile: reset memcombine correctly between basic blocks

randall77 · randall77 · commit 08cdfd06ed1c · 2023-09-15T21:33:40.000Z
Not sure why this bug didn't cause a complete failure, but it certainly makes for doing a lot more work than is necessary. Fixes #62604 Change-Id: If0be4acb6eafc3d7eeb42d2f4263c21b4e6e1c7d Reviewed-on: https://go-review.googlesource.com/c/go/+/527699 Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Heschi Kreinick <heschi@google.com>
diff --git a/src/cmd/compile/internal/ssa/memcombine.go b/src/cmd/compile/internal/ssa/memcombine.go
@@ -41,6 +41,7 @@ func memcombineLoads(f *Func) {
 		}
 	}
 	for _, b := range f.Blocks {
+		order = order[:0]
 		for _, v := range b.Values {
 			if v.Op != OpOr16 && v.Op != OpOr32 && v.Op != OpOr64 {
 				continue

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@ func memcombineLoads(f *Func) {`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`	`for _, b := range f.Blocks {`
	`44`	`+ order = order[:0]`
`44`	`45`	`for _, v := range b.Values {`
`45`	`46`	`if v.Op != OpOr16 && v.Op != OpOr32 && v.Op != OpOr64 {`
`46`	`47`	`continue`