cmd/link: suppress -bind_at_load deprecation warning for ld-prime

cherrymui · cherrymui · commit 040dbf9c181a · 2023-08-16T18:42:08.000Z
ld-prime emits a deprecation warning for -bind_at_load. The flag is needed for plugins to not deadlock (#38824) when linking with older darwin linker. It is supposedly not needed with newer linker when chained fixups are used. For now, we always pass it, and suppress the warning. For #61229. Change-Id: I4b8a6f864a460c40dc38adbb533f664f7fd5343c Reviewed-on: https://go-review.googlesource.com/c/go/+/508696 Reviewed-by: Than McIntosh <thanm@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Cherry Mui <cherryyz@google.com>
diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go
@@ -1903,6 +1903,16 @@ func (ctxt *Link) hostlink() {
 				out = append(out[:i], out[i+len(noPieWarning):]...)
 			}
 		}
+		if ctxt.IsDarwin() {
+			const bindAtLoadWarning = "ld: warning: -bind_at_load is deprecated on macOS\n"
+			if i := bytes.Index(out, []byte(bindAtLoadWarning)); i >= 0 {
+				// -bind_at_load is deprecated with ld-prime, but needed for
+				// correctness with older versions of ld64. Swallow the warning.
+				// TODO: maybe pass -bind_at_load conditionally based on C
+				// linker version.
+				out = append(out[:i], out[i+len(bindAtLoadWarning):]...)
+			}
+		}
 		ctxt.Logf("%s", out)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1903,6 +1903,16 @@ func (ctxt *Link) hostlink() {`
`1903`	`1903`	`out = append(out[:i], out[i+len(noPieWarning):]...)`
`1904`	`1904`	`}`
`1905`	`1905`	`}`
	`1906`	`+ if ctxt.IsDarwin() {`
	`1907`	`+ const bindAtLoadWarning = "ld: warning: -bind_at_load is deprecated on macOS\n"`
	`1908`	`+ if i := bytes.Index(out, []byte(bindAtLoadWarning)); i >= 0 {`
	`1909`	`+ // -bind_at_load is deprecated with ld-prime, but needed for`
	`1910`	`+ // correctness with older versions of ld64. Swallow the warning.`
	`1911`	`+ // TODO: maybe pass -bind_at_load conditionally based on C`
	`1912`	`+ // linker version.`
	`1913`	`+ out = append(out[:i], out[i+len(bindAtLoadWarning):]...)`
	`1914`	`+ }`
	`1915`	`+ }`
`1906`	`1916`	`ctxt.Logf("%s", out)`
`1907`	`1917`	`}`
`1908`	`1918`