This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Default an empty constraint as any, not latest #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
default-emptyconstraint-to-unconstrained
branch
from
b99ecd0 to
81af9d6
Compare
This was referenced Jul 26, 2017
Closed
Member
|
oh, yes, this definitely makes a lot of sense. i think i'd assumed we were doing it this way already 😛 |
Collaborator
Author
|
I'm pretty sure that I misread a TODO and flipped the behavior a while back... 😝 |
Member
|
basic impl looks good, seems like we just need test fixes |
carolynvs
force-pushed
the
default-emptyconstraint-to-unconstrained
branch
from
81af9d6 to
ca54d47
Compare
Collaborator
Author
|
I've removed the offending the testdata, it really belonged in PR #898. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a package is specified without any restrictions, default the constraint to
gps.Any(), not latest from the default branch.Work in pending pull requests for the importers has made it clear that this change is universally needed and shouldn't be done one-off in each importer.