internal/poly1305: drop Go 1.12 compatibility by thaJeztah · Pull Request #239 · golang/crypto

thaJeztah · 2022-11-06T15:46:32Z

Other packages already dropped compatibility with go1.12, so it should be safe to remove it for this package as well.

gopherbot · 2022-11-06T15:50:33Z

This PR (HEAD: e79997e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/448239 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-11-14T20:01:35Z

Message from Roland Shoemaker:

Patch Set 1: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-11-14T20:07:16Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-11-14T20:12:28Z

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-11-14T21:27:05Z

Message from Joedian Reid:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:25:34Z

Message from Roland Shoemaker:

Patch Set 1: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:25:35Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:25:36Z

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T15:25:37Z

Message from Joedian Reid:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-25T17:15:41Z

This PR (HEAD: 87b7b8e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/448239.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Other packages already dropped compatibility with go1.12, so it should be safe to remove it for this package as well.

gopherbot · 2023-11-27T18:41:14Z

This PR (HEAD: 1971e03) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/448239.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-30T12:14:30Z

Message from Filippo Valsorda:

Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-30T12:20:45Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-12-30T12:12:19Z","revision":"0cc6f8e6f6f7d2917c571a254ec3457eb646f6f8"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-30T12:20:46Z

Message from Filippo Valsorda:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-30T12:20:46Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-30T12:20:47Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T14:25:19Z

Message from Joedian Reid:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T14:25:19Z

Message from Joedian Reid:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/448239.
After addressing review feedback, remember to publish your drafts!

Other packages already dropped compatibility with go1.12, so it should be safe to remove it for this package as well. Change-Id: Ieecc7cd06a0a4e69e8c1c09ef6fefe95d78ceb75 GitHub-Last-Rev: 1971e03 GitHub-Pull-Request: #239 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/448239 Reviewed-by: Joedian Reid <[email protected]> Auto-Submit: Filippo Valsorda <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Filippo Valsorda <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Reviewed-by: Matthew Dempsky <[email protected]>

gopherbot · 2024-01-02T21:03:12Z

This PR is being closed because golang.org/cl/448239 has been merged.

thaJeztah force-pushed the poly1305_drop_go1.12 branch from e79997e to 87b7b8e Compare September 25, 2023 17:09

internal/poly1305: drop Go 1.12 compatibility

1971e03

Other packages already dropped compatibility with go1.12, so it should be safe to remove it for this package as well.

thaJeztah force-pushed the poly1305_drop_go1.12 branch from 87b7b8e to 1971e03 Compare November 27, 2023 18:37

gopherbot closed this Jan 2, 2024

Conversation

thaJeztah commented Nov 6, 2022

Uh oh!

gopherbot commented Nov 6, 2022

Uh oh!

gopherbot commented Nov 14, 2022

Uh oh!

gopherbot commented Nov 14, 2022

Uh oh!

gopherbot commented Nov 14, 2022

Uh oh!

gopherbot commented Nov 14, 2022

Uh oh!

gopherbot commented Sep 25, 2023

Uh oh!

gopherbot commented Sep 25, 2023

Uh oh!

gopherbot commented Sep 25, 2023

Uh oh!

gopherbot commented Sep 25, 2023

Uh oh!

gopherbot commented Sep 25, 2023

Uh oh!

gopherbot commented Nov 27, 2023

Uh oh!

gopherbot commented Dec 30, 2023

Uh oh!

gopherbot commented Dec 30, 2023

Uh oh!

gopherbot commented Dec 30, 2023

Uh oh!

gopherbot commented Dec 30, 2023

Uh oh!

gopherbot commented Dec 30, 2023

Uh oh!

gopherbot commented Jan 2, 2024

Uh oh!

gopherbot commented Jan 2, 2024

Uh oh!

gopherbot commented Jan 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants