Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.53.0
Choose a base ref
...
head repository: golang/crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.54.0
Choose a head ref
  • 10 commits
  • 37 files changed
  • 6 contributors

Commits on Jun 9, 2026

  1. internal: remove wycheproof tests

    Equivalent coverage using newer Wycheproof vectors has been added to the
    standard library, alongside the implementations under test.
    
    In the case where the algorithm doesn't exist in the stdlib, but is
    intended to be supported there one day (e.g. chacha20poly1305) we flip
    the relationship and run the Wycheproof tests from the stdlib on the
    vendored /x/crypto. As a result the legacy Wycheproof coverage in this
    repo can be removed.
    
    Change-Id: Ic07d559e42599b715906f5bcc39be10944a8dde4
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/758420
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-by: Filippo Valsorda <[email protected]>
    Auto-Submit: Daniel McCarney <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    cpu committed Jun 9, 2026
    Configuration menu
    Copy the full SHA
    5f2de1a View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2026

  1. x509roots/fallback: update bundle

    This is an automated CL which updates the NSS root bundle.
    
    [git-generate]
    go generate ./x509roots
    
    Change-Id: I448f9962a67bf042b04a2e34f16ae02a004d6edd
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/791040
    Auto-Submit: Gopher Robot <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    gopherbot committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    55aec0a View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2026

  1. argon2: update RFC 9106 parameter recommendations

    Update the IDKey example to use RFC 9106's first recommended Argon2id
    option and clarify the relationship between the first and second
    recommended options.
    
    Fixes golang/go#79823
    
    Change-Id: If44a86a5a8112b02fab97b4d5e325fe91d6049ee
    GitHub-Last-Rev: a764ae6
    GitHub-Pull-Request: #357
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/789020
    Reviewed-by: Roland Shoemaker <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: [email protected] <[email protected]>
    harjothkhara authored and rolandshoemaker committed Jun 18, 2026
    Configuration menu
    Copy the full SHA
    0b316e7 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2026

  1. acme/autocert: fix data race in Manager.createCert

    Previously Manager.createCert() read state.locked without holding any
    lock, while the owner goroutine wrote state.locked = false under the
    state's write lock. Concurrent goroutines for the same domain raced on
    that field.
    
    We fix the issue by removing the certState.locked field and instead
    having Manager.certState() return an additional owner bool computed
    under the m.stateMu lock. This allows the Manager.createCert() caller to
    know whether it must block on the read lock and return the state handled
    by another goroutine, or instead do the work itself and release the
    write lock.
    
    A regression unit test is included that fails under -race without the
    fix, and passes with the fix in-place.
    
    Fixes golang/go#80119
    
    Change-Id: I0f4c5c98f7e6bcf1ab71a3c0707bb0c7ce73415b
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/793840
    Reviewed-by: Roland Shoemaker <[email protected]>
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: Carlos Amedee <[email protected]>
    Auto-Submit: Daniel McCarney <[email protected]>
    cpu authored and gopherbot committed Jun 26, 2026
    Configuration menu
    Copy the full SHA
    5b7f841 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2026

  1. ssh/agent: drain channel stderr in agent forwarders

    ForwardToAgent and ForwardToRemote only read the main stream of the
    [email protected] channels they accept. If a peer sends data on
    the channel's extended (stderr) stream the bytes accumulate in the
    client-side extPending buffer and the receive window is never
    replenished, because the window is only adjusted as a side effect of
    ReadExtended. That can pin up to channelWindowSize (2 MiB) of memory
    per channel and silently stalls any stderr traffic once the window is
    exhausted.
    
    The auth-agent protocol does not use stderr, so a well-behaved peer
    never sends anything on it. To stay tolerant of misbehaving peers
    without leaving the channel half-stuck, drain the stderr stream into
    io.Discard, mirroring the existing DiscardRequests pattern. The
    goroutine exits when the channel is closed because Stderr().Read
    returns io.EOF.
    
    Add a regression test that opens an agent-forwarding channel and
    writes more than the default window on the stderr stream from the
    server side. Without the fix the write blocks once the remote window
    is exhausted; with the fix the bytes are drained and the agent stream
    remains usable.
    
    Change-Id: Iadf8ea6ca726c058421bbc39f92e0100579fda17
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/783720
    Reviewed-by: Filippo Valsorda <[email protected]>
    Reviewed-by: Carlos Amedee <[email protected]>
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    drakkan committed Jun 29, 2026
    Configuration menu
    Copy the full SHA
    7d695da View commit details
    Browse the repository at this point in the history
  2. ssh: sanitize client disconnect messages

    A malicious peer can send control characters
    and escape sequences in SSH_MSG_DISCONNECT;
    strip these characters and %q escape it.
    
    Change-Id: I266f78630a7a816a79ce4dda568ce57d7c3f6fb0
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/780180
    Commit-Queue: Nicola Murino <[email protected]>
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: Neal Patel <[email protected]>
    Reviewed-by: Nicola Murino <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Nicola Murino <[email protected]>
    thatnealpatel authored and gopherbot committed Jun 29, 2026
    Configuration menu
    Copy the full SHA
    6435c37 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2026

  1. ssh/agent: enforce strict limits on DSA key parameters

    The parseDSAKey function constructed a *dsa.PrivateKey directly from the
    add-identity request without validating the key parameters. Unlike DSA
    certificates, whose parameters are checked by the ssh package when the
    certificate's public key is parsed, raw DSA keys added to the agent were
    not validated at all.
    
    Align the raw DSA key parsing with the validation already performed by
    the main ssh package.
    
    Fixes golang/go#79725
    
    Change-Id: I537cc2175d35c19848c90c68739cf94ba7b50e10
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/795422
    Reviewed-by: Roland Shoemaker <[email protected]>
    Reviewed-by: Junyang Shao <[email protected]>
    LUCI-TryBot-Result: [email protected] <[email protected]>
    drakkan committed Jun 30, 2026
    Configuration menu
    Copy the full SHA
    0471e79 View commit details
    Browse the repository at this point in the history
  2. ssh: verify declared key type matches decoded key in authorized_keys

    ParseAuthorizedKey and ParseKnownHosts previously ignored the key type
    field (e.g. "ssh-rsa") in each entry, relying solely on the type
    information embedded within the base64-encoded key blob.
    
    For ParseAuthorizedKey this also caused a single-token option to be
    silently dropped: a line such as "restrict <key>" (with the key type
    omitted) was parsed as an unrestricted key, because the option token
    landed in the key type position and was discarded together with its
    meaning. The same happens for no-pty, no-port-forwarding and the other
    single-word options. OpenSSH's sshkey_read rejects such lines outright,
    as the option token cannot be read as a key type.
    
    OpenSSH's sshkey_read also explicitly verifies that the key type
    declared in the text matches the type of the parsed key, returning
    SSH_ERR_KEY_TYPE_MISMATCH if they differ.
    
    This change adds, in both functions, a check that the declared key type
    matches the decoded key's type, returning an error for malformed lines
    where they diverge. This mirrors the fix already applied to the
    ssh/knownhosts package in CL 782427.
    
    Change-Id: I9163108d964de4be8a415fe0efd68e6b71f77990
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/792840
    Reviewed-by: Filippo Valsorda <[email protected]>
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Auto-Submit: Nicola Murino <[email protected]>
    Reviewed-by: Neal Patel <[email protected]>
    Reviewed-by: Junyang Shao <[email protected]>
    drakkan authored and gopherbot committed Jun 30, 2026
    Configuration menu
    Copy the full SHA
    7626c50 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2026

  1. openpgp: make the deprecation message more explicit

    The package is unmaintained, unsafe at any speed, and does not receive
    security fixes. Document that, and point at the ProtonMail fork for
    those that _must_ still use OpenPGP.
    
    Change-Id: Ia602eaaf9e08bd25389400ebe7f346b60bdb9d99
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/794200
    Auto-Submit: Roland Shoemaker <[email protected]>
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    rolandshoemaker authored and gopherbot committed Jul 7, 2026
    Configuration menu
    Copy the full SHA
    d9474cc View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2026

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I431b878ec8830bf1894ae19176b5984b00954557
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/798280
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    gopherbot committed Jul 8, 2026
    Configuration menu
    Copy the full SHA
    cdce021 View commit details
    Browse the repository at this point in the history
Loading