Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7067223
Choose a base ref
...
head repository: golang/crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d042a39
Choose a head ref
  • 5 commits
  • 10 files changed
  • 5 contributors

Commits on Mar 18, 2024

  1. all: remove redundant words in comments and fix some typos

    Change-Id: I3078492dc020770aca630e0b362df0212bd41e32
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/569156
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    cuishuang authored and gopherbot committed Mar 18, 2024
    Copy the full SHA
    b91329d View commit details

Commits on Mar 26, 2024

  1. x/crypto/chacha20: cleanup chacha_ppc64le.s

    - Adding PCALIGN before the loops
    - Changing WORD directive with corresponding Vector Merge EVEN/ODD word  instructions
    - Replacing Branch Conditional (BC) with its extended mnemonic form  BDNZ
    - VPERMXOR instruction usage in place of VXOR instructions followed by
      VRLW (rotate left) for cases of rotating in multiples of 8. This
      replacements give performace improvement both in time and space  of around 7%-8% as listed below
      using benchstat tool.
    
    goos: linux
    goarch: ppc64le
    pkg: golang.org/x/crypto/chacha20
    cpu: POWER10
                     | chacha20.prev.out |       chacha20.new.out            |
                     |      sec/op       |   sec/op     vs base              |
    ChaCha20/64              171.9n ± 0%   156.6n ± 1%  -8.90% (p=0.002 n=6)
    ChaCha20/256             165.5n ± 0%   152.4n ± 0%  -7.92% (p=0.002 n=6)
    ChaCha20/10x25           505.8n ± 0%   504.3n ± 2%  -0.32% (p=0.589 n=6)
    ChaCha20/4096            2.265µ ± 0%   2.052µ ± 0%  -9.40% (p=0.002 n=6)
    ChaCha20/100x40          5.359µ ± 3%   5.018µ ± 2%  -6.37% (p=0.002 n=6)
    ChaCha20/65536           35.71µ ± 0%   32.29µ ± 0%  -9.57% (p=0.002 n=6)
    ChaCha20/1000x65         44.63µ ± 0%   41.05µ ± 0%  -8.02% (p=0.002 n=6)
    geomean                  2.235µ        2.073µ       -7.26%
    
                     | chacha20.prev.out |          chacha20.new.out         |
                     |       B/s         |     B/s       vs base             |
    ChaCha20/64             355.1Mi ± 0%   389.8Mi ± 1%   +9.78% (p=0.002 n=6)
    ChaCha20/256            1.440Gi ± 0%   1.565Gi ± 0%   +8.62% (p=0.002 n=6)
    ChaCha20/10x25          471.3Mi ± 0%   472.8Mi ± 2%   +0.31% (p=0.589 n=6)
    ChaCha20/4096           1.684Gi ± 0%   1.859Gi ± 0%  +10.38% (p=0.002 n=6)
    ChaCha20/100x40         711.8Mi ± 3%   760.3Mi ± 2%   +6.80% (p=0.002 n=6)
    ChaCha20/65536          1.709Gi ± 0%   1.890Gi ± 0%  +10.59% (p=0.002 n=6)
    ChaCha20/1000x65        1.356Gi ± 0%   1.475Gi ± 0%   +8.72% (p=0.002 n=6)
    geomean                 957.3Mi        1.008Gi        +7.83%
    Change-Id: Ib31cb10a2a11eacdacf0272fbfd887eb5ccd8bcb
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/564797
    Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com>
    Run-TryBot: Paul Murphy <murp@ibm.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: David Chase <drchase@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    jkrishmys authored and laboger committed Mar 26, 2024
    Copy the full SHA
    8d0d405 View commit details

Commits on Apr 3, 2024

  1. ssh: add server side multi-step authentication

    Add support for sending back partial success to the client while
    handling authentication in the server. This is implemented by a special
    error that can be returned by any of the authentication methods, which
    contains the authentication methods to offer next.
    
    This patch is based on CL 399075 with some minor changes and the
    addition of test cases.
    
    Fixes golang/go#17889
    Fixes golang/go#61447
    Fixes golang/go#64974
    
    Co-authored-by: Peter Verraedt <peter.verraedt@kuleuven.be>
    Change-Id: I05c8f913bb407d22c2e41c4cbe965e36ab4739b0
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/516355
    Reviewed-by: Andrew Lytvynov <awly@tailscale.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    2 people authored and gopherbot committed Apr 3, 2024
    Copy the full SHA
    6f79b5a View commit details

Commits on Apr 4, 2024

  1. ssh: respect MaxAuthTries also for "none" auth attempts

    Only the first "none" auth attempt is allowed without penality
    
    Change-Id: Ibe776e968ba406445eeb94e8f1959383b88c98f7
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/575995
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
    Commit-Queue: Nicola Murino <nicola.murino@gmail.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    drakkan authored and gopherbot committed Apr 4, 2024
    Copy the full SHA
    b92bf94 View commit details
  2. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: Ib20227810c7e72942dd6fc33731fc613784aedec
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/576515
    Reviewed-by: Than McIntosh <thanm@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    gopherbot committed Apr 4, 2024
    Copy the full SHA
    d042a39 View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff 7067223...d042a39