Repository navigation
Conversation
The data migrator init container was removed in goharbor#1714, but values.yaml still has database.internal.initContainer.migrator and the README still documents its resources. No template reads the value any more, so setting it has no effect. Remove both. Signed-off-by: YoungjuKim <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1714 removed the data migrator init container from the internal database StatefulSet, but
values.yamlstill hasdatabase.internal.initContainer.migratorand the README still documentsdatabase.internal.initContainer.migrator.resources. No template reads the value any more, so setting it has no effect.Checked on a cluster running chart 1.19.2: the
harbor-databaseStatefulSet has a single init container,data-permissions-ensurer(driven bydatabase.internal.initContainer.permissions.resources). On main,grep -rn migrator templates/only matches thecomponent: migratorlabels of the pre-upgrade Job, which is unrelated.This removes the value (with its commented example) and the README row.
This change was drafted with AI assistance and reviewed by me.
🤖 Generated with Claude Code