Skip to content

fix: multiple UI/UX fixes for checkboxes, alignment, dark theme, and i18n#23439

Merged
stonezdj merged 1 commit into
goharbor:mainfrom
stonezdj:26jun25_free_worker
Jun 26, 2026
Merged

fix: multiple UI/UX fixes for checkboxes, alignment, dark theme, and i18n#23439
stonezdj merged 1 commit into
goharbor:mainfrom
stonezdj:26jun25_free_worker

Conversation

@stonezdj

@stonezdj stonezdj commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Enable worker list selectable and other UI regression issues

  - fix #50: Baseline misalignment between Checkbox and Text Field
  - fix #51: Project Quotas- keep the Text style consistence with previous version
  - fix #58: Alignment issue with "Cover all projects" checkbox and info icon
  - fix #59: Selected permissions checkboxes are dimmed/grayed out in dark theme
  - fix #60: Global search placeholder leaks raw key "GLOBAL_SEARCH.PLACE" and top nav chatters during language toggle
  - fix #62: Multi-selection checkboxes are missing in the Workers list table
  - add unit test for the free button

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj
stonezdj force-pushed the 26jun25_free_worker branch from 917a7ae to 96fdca0 Compare June 26, 2026 02:57
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.13%. Comparing base (f2eccb1) to head (7204cc5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...omponents/global-search/global-search.component.ts 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #23439      +/-   ##
==========================================
+ Coverage   66.11%   66.13%   +0.02%     
==========================================
  Files        1072     1072              
  Lines      116882   116884       +2     
  Branches     2964     2965       +1     
==========================================
+ Hits        77281    77306      +25     
+ Misses      35322    35300      -22     
+ Partials     4279     4278       -1     
Flag Coverage Δ
unittests 66.13% <75.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...omponents/global-search/global-search.component.ts 67.50% <75.00%> (+1.71%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stonezdj
stonezdj force-pushed the 26jun25_free_worker branch from 96fdca0 to 1967370 Compare June 26, 2026 03:27

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj
stonezdj force-pushed the 26jun25_free_worker branch 3 times, most recently from a48a5c0 to f31f2e0 Compare June 26, 2026 09:28
@wy65701436

Copy link
Copy Markdown
Contributor

Please update the commit to tell what issues are fixed, thanks.

@stonezdj
stonezdj force-pushed the 26jun25_free_worker branch from f31f2e0 to 0dd6cca Compare June 26, 2026 09:38
  - fix goharbor#50: Baseline misalignment between Checkbox and Text Field
  - fix goharbor#51: Project Quotas- keep the Text style consistence with previous version
  - fix goharbor#58: Alignment issue with "Cover all projects" checkbox and info icon
  - fix goharbor#59: Selected permissions checkboxes are dimmed/grayed out in dark theme
  - fix goharbor#60: Global search placeholder leaks raw key "GLOBAL_SEARCH.PLACE" and top nav chatters during language toggle
  - fix goharbor#62: Multi-selection checkboxes are missing in the Workers list table
  - add unit test for the free button

Signed-off-by: wang yan <[email protected]>
Signed-off-by: stonezdj <[email protected]>
@stonezdj
stonezdj force-pushed the 26jun25_free_worker branch from 0dd6cca to 7204cc5 Compare June 26, 2026 09:39
@wy65701436 wy65701436 changed the title Enable worker list selectable fix: multiple UI/UX fixes for checkboxes, alignment, dark theme, and i18n Jun 26, 2026
@stonezdj
stonezdj enabled auto-merge (squash) June 26, 2026 09:40
@stonezdj
stonezdj merged commit 1ace7d6 into goharbor:main Jun 26, 2026
12 checks passed
stonezdj added a commit that referenced this pull request Jun 26, 2026
#23440)

Enable worker list selectable and other UI regression issues

  - fix #50: Baseline misalignment between Checkbox and Text Field
  - fix #51: Project Quotas- keep the Text style consistence with previous version
  - fix #58: Alignment issue with "Cover all projects" checkbox and info icon
  - fix #59: Selected permissions checkboxes are dimmed/grayed out in dark theme
  - fix #60: Global search placeholder leaks raw key "GLOBAL_SEARCH.PLACE" and top nav chatters during language toggle
  - fix #62: Multi-selection checkboxes are missing in the Workers list table
  - add unit test for the free button

Signed-off-by: wang yan <[email protected]>
Signed-off-by: stonezdj <[email protected]>
NishchayRajput pushed a commit to NishchayRajput/harbor that referenced this pull request Jul 4, 2026
…i18n (goharbor#23439)

Enable worker list selectable and other UI regression issues

  - fix goharbor#50: Baseline misalignment between Checkbox and Text Field
  - fix goharbor#51: Project Quotas- keep the Text style consistence with previous version
  - fix goharbor#58: Alignment issue with "Cover all projects" checkbox and info icon
  - fix goharbor#59: Selected permissions checkboxes are dimmed/grayed out in dark theme
  - fix goharbor#60: Global search placeholder leaks raw key "GLOBAL_SEARCH.PLACE" and top nav chatters during language toggle
  - fix goharbor#62: Multi-selection checkboxes are missing in the Workers list table
  - add unit test for the free button

Signed-off-by: wang yan <[email protected]>
Signed-off-by: stonezdj <[email protected]>
NishchayRajput pushed a commit to NishchayRajput/harbor that referenced this pull request Jul 4, 2026
…i18n (goharbor#23439)

Enable worker list selectable and other UI regression issues

  - fix goharbor#50: Baseline misalignment between Checkbox and Text Field
  - fix goharbor#51: Project Quotas- keep the Text style consistence with previous version
  - fix goharbor#58: Alignment issue with "Cover all projects" checkbox and info icon
  - fix goharbor#59: Selected permissions checkboxes are dimmed/grayed out in dark theme
  - fix goharbor#60: Global search placeholder leaks raw key "GLOBAL_SEARCH.PLACE" and top nav chatters during language toggle
  - fix goharbor#62: Multi-selection checkboxes are missing in the Workers list table
  - add unit test for the free button

Signed-off-by: wang yan <[email protected]>
Signed-off-by: stonezdj <[email protected]>
Signed-off-by: Nishchay Rajput <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants