Skip to content

cherry-pick: fix(ui): fix UI issues #48–#54 across portal components (#23427) to release-2.15.0#23428

Merged
chlins merged 1 commit into
goharbor:release-2.15.0from
stonezdj:cherrypick-fix-ui-ux-to-2.15.0
Jun 24, 2026
Merged

cherry-pick: fix(ui): fix UI issues #48–#54 across portal components (#23427) to release-2.15.0#23428
chlins merged 1 commit into
goharbor:release-2.15.0from
stonezdj:cherrypick-fix-ui-ux-to-2.15.0

Conversation

@stonezdj

Copy link
Copy Markdown
Contributor

Summary

Cherry-pick of the UI/UX fixes across portal components to release-2.15.0.

Original PR: #23427

  • Issue 48: Links turn red on click — add global a { color: var(--clr-link-color) } override in global.scss so active/visited anchor color stays consistent
  • Issue 49: Edit Endpoint modal shows green outlines on open — wrap the form in @if (createEditDestinationOpened) so Clarity does not pre-initialize and validate the form before the modal is actually opened
  • Issue 52/53: Copy button icon state broken — replace [class.is-success] / [class.is-error] with [status] binding in copy-input component so icon correctly reflects copied / error / default states
  • Issue 54: Sign-up / new-user form layout misaligned — add clrForm, clrLayout, clrLabelSize="4", clr-row and responsive grid classes to new-user-form; wrap input + icon combos in div.clr-input-group in sign-in, account-settings and create-project to fix horizontal label-input alignment
  • Also replace deprecated class="is-error" with status="danger" on clr-icon in sbom-scan and vulnerability result-bar-chart components; normalize global.scss indentation from 2-space to 4-space throughout

Test plan

  • Verified locally

Signed-off-by: Ashish Patel [email protected]
Signed-off-by: stonezdj [email protected]

Made with Cursor

@stonezdj
stonezdj requested a review from a team as a code owner June 24, 2026 08:57
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-2.15.0@1c378ee). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.15.0   #23428   +/-   ##
=================================================
  Coverage                  ?   66.06%           
=================================================
  Files                     ?     1073           
  Lines                     ?   116713           
  Branches                  ?     2955           
=================================================
  Hits                      ?    77109           
  Misses                    ?    35336           
  Partials                  ?     4268           
Flag Coverage Δ
unittests 66.06% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...te-edit-endpoint/create-edit-endpoint.component.ts 37.19% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stonezdj
stonezdj marked this pull request as draft June 24, 2026 09:24
- goharbor#48: Links turn red on click — add global `a { color: var(--clr-link-color) }`
  override in global.scss so active/visited anchor color stays consistent
- goharbor#49: Edit Endpoint modal shows green outlines on open — wrap the form in
  @if (createEditDestinationOpened) so Clarity does not pre-initialize and
  validate the form before the modal is actually opened
- goharbor#52/goharbor#53: Copy button icon state broken — replace [class.is-success] /
  [class.is-error] with [status] binding in copy-input component so icon
  correctly reflects copied / error / default states
- goharbor#54: Sign-up / new-user form layout misaligned — add clrForm, clrLayout,
  clrLabelSize="4", clr-row and responsive grid classes to new-user-form;
  wrap input + icon combos in div.clr-input-group in sign-in, account-settings
  and create-project to fix horizontal label-input alignment
- Also replace deprecated class="is-error" with status="danger" on clr-icon
  in sbom-scan and vulnerability result-bar-chart components; normalize
  global.scss indentation from 2-space to 4-space throughout
- Fix lint issue
- fix targetEndpoint validation issue
- fix copilot review comments

Signed-off-by: Ashish Patel <[email protected]>
Signed-off-by: stonezdj <[email protected]>

fix the copilot review

Signed-off-by: stonezdj <[email protected]>
@stonezdj
stonezdj force-pushed the cherrypick-fix-ui-ux-to-2.15.0 branch from 7b9b192 to d17917c Compare June 24, 2026 09:43
@wy65701436
wy65701436 marked this pull request as ready for review June 24, 2026 11:26

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins
chlins merged commit a64138d into goharbor:release-2.15.0 Jun 24, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants