[CHERRY-PICK] fix: Bump repository update_time on tag and artifact changes (#23225)#23292
Merged
Merged
Conversation
…r#23225) fix: bump repository update_time on tag and artifact changes Fixes goharbor#23149. The "Last Modified Time" column on the repository list only moved when an image was pushed. Adding or deleting a tag from the UI, or deleting an artifact, left the timestamp stale. This wires update_time bumps into: - Tag create, delete, and retag (both UI and registry push) - Artifact create and delete A new repository.Manager.Touch method does the actual update and invalidates the redis cache. It's skipped on tag-create conflicts so a duplicate push doesn't falsely advance the timestamp. The change is repo-only on purpose: artifacts are addressed by their immutable digest, so an artifact update_time has no use. Signed-off-by: aloui ikram <[email protected]> Co-authored-by: aloui ikram <[email protected]> Co-authored-by: Chlins Zhang <[email protected]> Signed-off-by: chlins <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-2.15.0 #23292 +/- ##
=================================================
Coverage ? 65.97%
=================================================
Files ? 1074
Lines ? 116740
Branches ? 2952
=================================================
Hits ? 77016
Misses ? 35447
Partials ? 4277
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
stonezdj
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: bump repository update_time on tag and artifact changes
Fixes #23149.
The "Last Modified Time" column on the repository list only moved when an image was pushed. Adding or deleting a tag from the UI, or deleting an artifact, left the timestamp stale.
This wires update_time bumps into:
A new repository.Manager.Touch method does the actual update and invalidates the redis cache. It's skipped on tag-create conflicts so a duplicate push doesn't falsely advance the timestamp.
The change is repo-only on purpose: artifacts are addressed by their immutable digest, so an artifact update_time has no use.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: