Skip to content

[CHERRY-PICK] support configurable PIP_INDEX_URL for swagger client build (#23241)#23242

Merged
wy65701436 merged 1 commit into
goharbor:release-2.15.0from
stonezdj:cherry-pick/23241-to-release-2.15.0
May 15, 2026
Merged

[CHERRY-PICK] support configurable PIP_INDEX_URL for swagger client build (#23241)#23242
wy65701436 merged 1 commit into
goharbor:release-2.15.0from
stonezdj:cherry-pick/23241-to-release-2.15.0

Conversation

@stonezdj

Copy link
Copy Markdown
Contributor

Cherry-pick of #23241 to release-2.15.0.

What

Pass PIP_INDEX_URL through Makefile (conditional env injection), APITest-Util.robot (robot variable with public PyPI default), and Group3-Upgrade/run.sh (-v forwarding to robot).

Conflict resolution

In tests/resources/APITest-Util.robot, the variable was renamed from ${OPENAPI_GENERATOR_CLI_URL_DEFAULT} to ${OPENAPI_GENERATOR_CLI_URL} (to match the already-applied keyword section), and ${PIP_INDEX_URL} was added. JFROG variables were omitted since they are not present in the release-2.15.0 branch.

@stonezdj
stonezdj requested a review from a team as a code owner May 15, 2026 02:57
@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-2.15.0@562b3e9). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.15.0   #23242   +/-   ##
=================================================
  Coverage                  ?   65.99%           
=================================================
  Files                     ?     1074           
  Lines                     ?   116684           
  Branches                  ?     2952           
=================================================
  Hits                      ?    77000           
  Misses                    ?    35412           
  Partials                  ?     4272           
Flag Coverage Δ
unittests 65.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pass PIP_INDEX_URL through Makefile (conditional env injection),
APITest-Util.robot (robot variable with public PyPI default), and
Group3-Upgrade/run.sh (-v forwarding to robot).

Signed-off-by: stonezdj <[email protected]>
@stonezdj
stonezdj force-pushed the cherry-pick/23241-to-release-2.15.0 branch from 54587ff to 7d959ee Compare May 15, 2026 03:33
@stonezdj stonezdj added the release-note/infra Infra related changes e.g. release, test, ship etc... label May 15, 2026

@chlins chlins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fiona-xie fiona-xie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436
wy65701436 merged commit 03162e2 into goharbor:release-2.15.0 May 15, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/infra Infra related changes e.g. release, test, ship etc...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants