Skip to content

(cherry-pick) Fix the issue distribution instance edit without creden…#23220

Merged
chlins merged 1 commit into
goharbor:release-2.14.0from
chlins:release-2.14/26apr23_fix_ui_p2p_preheat_edit
May 9, 2026
Merged

(cherry-pick) Fix the issue distribution instance edit without creden…#23220
chlins merged 1 commit into
goharbor:release-2.14.0from
chlins:release-2.14/26apr23_fix_ui_p2p_preheat_edit

Conversation

@chlins

@chlins chlins commented May 9, 2026

Copy link
Copy Markdown
Member

…tial can not save (#23166)

Fix the issue distribution instance edit without credential can not save

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins
chlins requested a review from a team as a code owner May 9, 2026 03:09
…tial can not save (goharbor#23166)

Fix the issue distribution instance edit without credential can not save

Signed-off-by: stonezdj <[email protected]>
Signed-off-by: chlins <[email protected]>
@chlins
chlins force-pushed the release-2.14/26apr23_fix_ui_p2p_preheat_edit branch from 402a238 to 09a9bd3 Compare May 9, 2026 03:10
@chlins
chlins enabled auto-merge (squash) May 9, 2026 03:10
@codecov

codecov Bot commented May 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-2.14.0@3d4bfdc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...-setup-modal/distribution-setup-modal.component.ts 30.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.14.0   #23220   +/-   ##
=================================================
  Coverage                  ?   65.83%           
=================================================
  Files                     ?     1073           
  Lines                     ?   116273           
  Branches                  ?     2944           
=================================================
  Hits                      ?    76549           
  Misses                    ?    35470           
  Partials                  ?     4254           
Flag Coverage Δ
unittests 65.83% <30.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-setup-modal/distribution-setup-modal.component.ts 35.26% <30.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins
chlins merged commit 79a297f into goharbor:release-2.14.0 May 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants