Skip to content

(cherry-pick) Fix the issue distribution instance edit without credential can not save#23166

Merged
stonezdj merged 1 commit into
goharbor:release-2.15.0from
stonezdj:26apr23_fix_ui_p2p_preheat_edit
Apr 23, 2026
Merged

(cherry-pick) Fix the issue distribution instance edit without credential can not save#23166
stonezdj merged 1 commit into
goharbor:release-2.15.0from
stonezdj:26apr23_fix_ui_p2p_preheat_edit

Conversation

@stonezdj

Copy link
Copy Markdown
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-2.15.0@45f9c70). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...-setup-modal/distribution-setup-modal.component.ts 30.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.15.0   #23166   +/-   ##
=================================================
  Coverage                  ?   65.99%           
=================================================
  Files                     ?     1074           
  Lines                     ?   116684           
  Branches                  ?     2952           
=================================================
  Hits                      ?    77005           
  Misses                    ?    35407           
  Partials                  ?     4272           
Flag Coverage Δ
unittests 65.99% <30.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-setup-modal/distribution-setup-modal.component.ts 35.26% <30.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chlins chlins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj
stonezdj force-pushed the 26apr23_fix_ui_p2p_preheat_edit branch from a215201 to 9aff27e Compare April 23, 2026 07:02

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj
stonezdj merged commit 805f1c5 into goharbor:release-2.15.0 Apr 23, 2026
12 checks passed
chlins pushed a commit to chlins/harbor that referenced this pull request May 9, 2026
…tial can not save (goharbor#23166)

Fix the issue distribution instance edit without credential can not save

Signed-off-by: stonezdj <[email protected]>
Signed-off-by: chlins <[email protected]>
chlins added a commit that referenced this pull request May 9, 2026
#23220)

(cherry-pick) Fix the issue distribution instance edit without credential can not save (#23166)

Fix the issue distribution instance edit without credential can not save

Signed-off-by: stonezdj <[email protected]>
Signed-off-by: chlins <[email protected]>
Co-authored-by: stonezdj(Daojun Zhang) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants