Skip to content

(cherry-pick) Fix issue related to scanner API#23109

Merged
wy65701436 merged 1 commit into
goharbor:release-2.14.0from
stonezdj:2.14_fix_scanner_api
Apr 14, 2026
Merged

(cherry-pick) Fix issue related to scanner API#23109
wy65701436 merged 1 commit into
goharbor:release-2.14.0from
stonezdj:2.14_fix_scanner_api

Conversation

@stonezdj

@stonezdj stonezdj commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj
stonezdj requested a review from a team as a code owner April 14, 2026 06:55
@stonezdj stonezdj added the release-note/update Update or Fix label Apr 14, 2026
@stonezdj stonezdj changed the title Fix issue related to scanner API (cherry-pick) Fix issue related to scanner API Apr 14, 2026
@codecov

codecov Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 43.29268% with 93 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-2.14.0@887761a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/pkg/scan/scanner/manager.go 43.39% 20 Missing and 10 partials ⚠️
src/server/v2.0/handler/preheat.go 0.00% 29 Missing ⚠️
src/lib/config/systemconfig.go 34.61% 12 Missing and 5 partials ⚠️
src/pkg/p2p/preheat/instance/manager.go 44.44% 8 Missing and 7 partials ⚠️
src/pkg/reg/manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.14.0   #23109   +/-   ##
=================================================
  Coverage                  ?   65.85%           
=================================================
  Files                     ?     1073           
  Lines                     ?   116233           
  Branches                  ?     2933           
=================================================
  Hits                      ?    76541           
  Misses                    ?    35434           
  Partials                  ?     4258
Flag Coverage Δ
unittests 65.85% <43.29%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/server/v2.0/handler/model/scanner.go 76.74% <100.00%> (ø)
src/server/v2.0/handler/scanner.go 92.07% <100.00%> (ø)
src/pkg/reg/manager.go 57.85% <0.00%> (ø)
src/pkg/p2p/preheat/instance/manager.go 53.12% <44.44%> (ø)
src/lib/config/systemconfig.go 47.85% <34.61%> (ø)
src/server/v2.0/handler/preheat.go 19.25% <0.00%> (ø)
src/pkg/scan/scanner/manager.go 39.25% <43.39%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

wy65701436
wy65701436 approved these changes Apr 14, 2026
View reviewed changes

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chlins
chlins approved these changes Apr 14, 2026
View reviewed changes

@chlins chlins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436
wy65701436 enabled auto-merge (squash) April 14, 2026 07:12
@wy65701436
wy65701436 merged commit b1a0d11 into goharbor:release-2.14.0 Apr 14, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes
@chlins chlins chlins approved these changes

Assignees

@chlins chlins

@MinerYang MinerYang

Labels

release-note/update Update or Fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stonezdj @wy65701436 @chlins @OrlinVasilev @MinerYang