Skip to content

[CHERRY-PICK] feat(session): prevent background polling from renewing session TTL#23098

Merged
chlins merged 1 commit into
goharbor:release-2.14.0from
chlins:release-2.14/refactor/session
Apr 14, 2026
Merged

[CHERRY-PICK] feat(session): prevent background polling from renewing session TTL#23098
chlins merged 1 commit into
goharbor:release-2.14.0from
chlins:release-2.14/refactor/session

Conversation

@chlins

@chlins chlins commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Cherry pick of #22980

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins
chlins requested a review from a team as a code owner April 13, 2026 08:58
@chlins
chlins enabled auto-merge (squash) April 13, 2026 08:58
@codecov

codecov Bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.33333% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-2.14.0@859d9a5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/core/session/session.go 28.57% 4 Missing and 1 partial ⚠️
...oard/job-service-dashboard-health-check.service.ts 40.00% 3 Missing ⚠️
.../portal/src/app/services/intercept-http.service.ts 25.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.14.0   #23098   +/-   ##
=================================================
  Coverage                  ?   65.86%           
=================================================
  Files                     ?     1073           
  Lines                     ?   116127           
  Branches                  ?     2933           
=================================================
  Hits                      ?    76488           
  Misses                    ?    35399           
  Partials                  ?     4240
Flag Coverage Δ
unittests 65.86% <85.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/context.go 100.00% <100.00%> (ø)
...audit-log-purge/history/purge-history.component.ts 41.37% <100.00%> (ø)
...g-job/audit-log-purge/set-job/set-job.component.ts 45.04% <100.00%> (ø)
...-job/gc-page/gc/gc-history/gc-history.component.ts 40.56% <100.00%> (ø)
...t-side-nav/clearing-job/gc-page/gc/gc.component.ts 62.50% <100.00%> (ø)
...es/vulnerability/vulnerability-config.component.ts 63.23% <100.00%> (ø)
...ard/pending-job-card/pending-job-card.component.ts 50.79% <100.00%> (ø)
...dashboard/schedule-card/schedule-card.component.ts 44.11% <100.00%> (ø)
...ice-dashboard/worker-card/worker-card.component.ts 56.00% <100.00%> (ø)
...n/replication-tasks/replication-tasks.component.ts 50.47% <100.00%> (ø)
... and 14 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

wy65701436
wy65701436 approved these changes Apr 13, 2026
View reviewed changes

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins
chlins force-pushed the release-2.14/refactor/session branch from 2b7b110 to 95f8346 Compare April 13, 2026 09:04
@chlins
chlins merged commit 887761a into goharbor:release-2.14.0 Apr 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stonezdj stonezdj stonezdj approved these changes
@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@Vad1mo Vad1mo

@wy65701436 wy65701436

@OrlinVasilev OrlinVasilev

Labels

release-note/update Update or Fix target/2.14.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chlins @stonezdj @wy65701436 @Vad1mo @OrlinVasilev