Skip to content

fix(artifact): correct typo in artifact_type column definition#22656

Merged
chlins merged 2 commits into
goharbor:mainfrom
chlins:fix/column-typo
Dec 22, 2025
Merged

fix(artifact): correct typo in artifact_type column definition#22656
chlins merged 2 commits into
goharbor:mainfrom
chlins:fix/column-typo

Conversation

@chlins

@chlins chlins commented Dec 19, 2025

Copy link
Copy Markdown
Member

This pull request corrects a typo in the struct tag for the ArtifactType field in the Artifact struct. The tag is now properly set to column(artifact_type), which ensures correct ORM mapping and data storage.

  • Fixed the struct tag for the ArtifactType field in the Artifact struct in model.go to use column(artifact_type) instead of the misspelled colume(artifact_type).

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added the release-note/update Update or Fix label Dec 19, 2025
@chlins
chlins requested a review from a team as a code owner December 19, 2025 03:10
@codecov

codecov Bot commented Dec 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.86%. Comparing base (c8c11b4) to head (cdd8ebf).
⚠️ Report is 611 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22656       +/-   ##
===========================================
+ Coverage   45.36%   65.86%   +20.49%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116095   +102762     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76463    +70414     
- Misses       6983    35393    +28410     
- Partials      301     4239     +3938     
Flag Coverage Δ
unittests 65.86% <ø> (+20.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/pkg/artifact/dao/model.go 100.00% <ø> (ø)

... and 986 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MinerYang MinerYang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins
chlins enabled auto-merge (squash) December 19, 2025 08:21

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins
chlins merged commit cd46a58 into goharbor:main Dec 22, 2025
12 checks passed
intojhanurag pushed a commit to intojhanurag/harbor that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants