Skip to content

fix: support both docker-compose v1 and docker compose v2#22581

Merged
wy65701436 merged 1 commit into
goharbor:mainfrom
Coldchen99:c.c/feat/composev2
Nov 26, 2025
Merged

fix: support both docker-compose v1 and docker compose v2#22581
wy65701436 merged 1 commit into
goharbor:mainfrom
Coldchen99:c.c/feat/composev2

Conversation

@Coldchen99

Copy link
Copy Markdown
Contributor

Add fallback to support Docker Compose V2 plugin format when standalone docker-compose binary is not available.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Add fallback to support Docker Compose V2 plugin format when
standalone docker-compose binary is not available.

Signed-off-by: coldenchen <[email protected]>
@Coldchen99
Coldchen99 requested a review from a team as a code owner November 21, 2025 03:29
@codecov

codecov Bot commented Nov 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.85%. Comparing base (c8c11b4) to head (c6d6d25).
⚠️ Report is 596 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22581       +/-   ##
===========================================
+ Coverage   45.36%   65.85%   +20.48%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116095   +102762     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76453    +70404     
- Misses       6983    35405    +28422     
- Partials      301     4237     +3936     
Flag Coverage Δ
unittests 65.85% <ø> (+20.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 987 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 added the release-note/update Update or Fix label Nov 26, 2025
@wy65701436
wy65701436 enabled auto-merge (squash) November 26, 2025 05:57
@wy65701436
wy65701436 merged commit 8c3f0c6 into goharbor:main Nov 26, 2025
18 of 20 checks passed
vg006 pushed a commit to vg006/harbor that referenced this pull request Dec 4, 2025
…2581)

fix: resolve 'docker-compose: command not found' error

Add fallback to support Docker Compose V2 plugin format when
standalone docker-compose binary is not available.

Signed-off-by: coldenchen <[email protected]>
Co-authored-by: coldenchen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants