Repository navigation
Full Multi-Architecture Enablement for Harbor (amd64 + arm64) - #22311
Conversation
eb33291 to
5edb421
Compare
…tions Signed-off-by: Ubuntu <[email protected]> Signed-off-by: Rani Chowdary Mandepudi <[email protected]>
Signed-off-by: Rani Chowdary Mandepudi <[email protected]>
Signed-off-by: Rani Chowdary Mandepudi <[email protected]>
5edb421 to
c1dd001
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22311 +/- ##
==========================================
- Coverage 66.04% 66.02% -0.02%
==========================================
Files 1074 1074
Lines 116799 116799
Branches 2955 2955
==========================================
- Hits 77139 77121 -18
- Misses 35380 35393 +13
- Partials 4280 4285 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@wy65701436 @OrlinVasilev @chlins Any suggestions on the pr ? |
|
@ranimandepudi, can you resolve the conflicts.
This is a more general question: So we actually need to perform all the tests on both architectures, AMD and ARM? |
|
@Vad1mo |
|
@wy65701436 @OrlinVasilev @chlins Can you please review it ? |
|
@ranimandepudi Please resolve the conflict, and it seems it will break current CI pass right now. |
Signed-off-by: Rani Chowdary Mandepudi <[email protected]>
Signed-off-by: Mandepudi Rani Chowdary <[email protected]>
|
@Vad1mo @chlins @wy65701436 @OrlinVasilev |
@ranimandepudi CI rerun failed, please fix the failed actions. |
Signed-off-by: Rani Chowdary Mandepudi <[email protected]>
|
@wy65701436 looks like we are good to merge ? |
|
@wy65701436 @chlins Can you please review this PR ? |
Signed-off-by: bupd <[email protected]>
bupd
left a comment
There was a problem hiding this comment.
/lgtm
I have tested and verified the builds and the ci - works as expected.
Thanks everyone.
|
Hi team, could you please let me know if there’s an expected timeline for merging this? Thanks! |
Upstream-PR: goharbor/harbor#22311 Upstream-Author: @ranimandepudi Signed-off-by: Prasanth Baskar <[email protected]>
…ation - README: add Known Limitations (exporter amd64-only on v2.15.x tags, root-caused to upstream GOARCH=amd64 hardcode since v2.2.0; fix goharbor#22311 is master-only/unreleased) + :latest-tracks-newest-build note + redis->valkey (v2.15.2, goharbor#23157) cache-backend note. - plan doc: correct the false "v2.15.2+ ships multiarch exporter" claim (multiarch exporter Dockerfile is fork-main-only, absent from all GA tags) and record the 2026-07-07 :latest->v2.15.2 reconciliation run (run 28865019658; latest==v2.15.2 verified for all 7 tag-published components incl valkey-photon). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
… to main, release-pending goharbor#22311 "Full Multi-Architecture Enablement" is merged to upstream main (2026-05-12) and already synced into this fork's main (exporter Dockerfile now uses GOARCH=${TARGETARCH}), but is in no release tag yet — all v2.15.x predate it. Records: - README: exporter note updated (fix merged+synced, not just "on master"). - plan doc: new "Upstream tracking goharbor#22311" subsection — fork's own exporter Dockerfile.multiarch is now redundant on main; and the build-package.yml exporter skip must be lifted for the first release containing goharbor#22311 (expected v2.16.0), while v2.15.x keeps the skip. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
PR goharbor#22311 (goharbor#22311) introduced an empty online installer argument for RC releases. The unquoted argument was omitted, shifting the remaining arguments and leaving getAssets without its final assetsPath parameter. Quote all getAssets arguments to preserve the empty argument. Signed-off-by: stonezdj <[email protected]>
fix(release): handle empty parameter introduced by #22311 PR #22311 (#22311) introduced an empty online installer argument for RC releases. The unquoted argument was omitted, shifting the remaining arguments and leaving getAssets without its final assetsPath parameter. Quote all getAssets arguments to preserve the empty argument. (cherry picked from commit 27ea4ac) Signed-off-by: stonezdj <[email protected]>
fix(release): handle empty parameter introduced by #22311 PR #22311 (#22311) introduced an empty online installer argument for RC releases. The unquoted argument was omitted, shifting the remaining arguments and leaving getAssets without its final assetsPath parameter. Quote all getAssets arguments to preserve the empty argument. Signed-off-by: stonezdj <[email protected]>
This PR completes the multi-architecture enablement for Harbor. It builds on #22229 and expands it from CI-only coverage into full tooling, release plumbing, and multi-arch image publishing.
Changes:
Step 1: CI Matrix:
UTTEST
APITEST_DB
APITEST_DB_PROXY_CACHE
APITEST_LDAP
OFFLINE
UI_UT
Step 2: Tooling Neutrality:
Step 3: Release Plumbing:
Step 4: Multi-Arch Image Publishing:
Expected Behavior:
PR CI runs on both amd64 and arm64; all jobs pass (offline + online).
Offline and online installers are produced for both arches.
docker pull goharbor/core: resolves automatically to the native image on amd64 or arm64.
Developers can build and run Harbor from source on arm64 using:
make compilemake build -e VERSIONTAG=dev -e BASEIMAGETAG=dev -e PULL_BASE_FROM_DOCKERHUB=false -e PUSHBASEIMAGE=false -e BUILD_BASE=true -e TRIVYFLAG=true -e BUILDTRIVYADP=trueRoadMap Discussed:
Step 1: CI coverage
Step 2: Tooling Neutrality
Step 3: Release Plumbing
Step 4: Multi-Arch image publishing
With this PR, Harbor achieves full parity on amd64 and arm64, covering source builds, CI, release workflows, and published images.
Thanks
Thanks to the Harbor maintainers and community for reviewing this. This contribution ensures Harbor is production-ready on modern Arm platforms, aligning with CNCF best practices for multi-arch support.