Support for video files using the HTML5 video tag #3967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
hi, could you send PR to Gitea also? Gitea LFS with video will be useful! |
Contributor
Author
|
@lunny Sure, the PR to gitea is at go-gitea/gitea#418 |
Member
|
Thanks! |
Martchus
pushed a commit
to Martchus/gogs
that referenced
this pull request
Aug 27, 2018
…ithout changing language (gogs#3967)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds support for video files using the HTML5 video tag. This allows viewing videos files directly in the webinterface - essentially the same way PDF files are supported.
Video files are not ideal to be managed using git, but may be stored in repositories as part of a projects documentation. This is the case in a project I am currently working on, and it helps a lot being able to preview these files directly in gogs instead of having to download and to open them in a video player. With video support in most of the current browsers (http://caniuse.com/#search=video) this seems like a helpful feature to be implemented in gogs.