Don't use custom PBKDF2 function #3952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, use golang.org/x/crypto/pbkdf2
Contributor
|
Hi, could you send a PR to github.com/go-gitea/gitea too? |
Contributor
|
@leonklingele because at the time this was implemented, that package didn't exist officially :) |
Contributor
Author
|
@lunny why not apply the patch yourself? ;) |
Contributor
|
@leonklingele OK. I will do it and reference to this issue. |
Contributor
Because it's a community project ;) |
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know why we'd want to duplicate something which already exists in
golang.org/x/crypto/pbkdf2