Repository navigation
fix(os/gproc): skip unix-only pid mapping folders on windows - #4956
Merged
Merged
Conversation
gproc stores its pid to port mapping files in the first writable folder of "/var/tmp", "/var/run", "~/.config" and the temp folder. On Windows the first two resolve to the root of the current drive, so Send/Receive created "C:\var\tmp\gf_pid_port_mapping". Only try them on Unix-like systems. Fixes gogf#4136 Co-Authored-By: Claude Opus 5.5 <[email protected]>
hailaz
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4136
gproc keeps its pid to port mapping files in the first writable folder of
/var/tmp,/var/run,~/.configand the temp folder. On Windows/var/tmpis a drive-relative path, sogproc.Send/gproc.ReceivecreatedC:\var\tmp\gf_pid_port_mappingin the root of the current drive.This keeps
/var/tmpand/var/runfor Unix-like systems only. On Windows the existing next candidates are used (%USERPROFILE%\.config\gf_pid_port_mapping, then the temp folder); sender and receiver still agree because they use the same list.Test_getCommPidFolderPath_NotInDriveRootOnWindowsfails on master on Windows. Since CI runs on Linux,Test_getCommPidSystemFolderPathschecks the folder list on every platform.I used Claude Code to write this change.