fix: deduplicate UUID parsing logic with parsing tests #217;#218
Merged
Conversation
Signed-off-by: Abdurakhman R. <[email protected]>
3 tasks
kohenkatz
reviewed
Jul 4, 2025
Signed-off-by: Abdurakhman R. <[email protected]>
Signed-off-by: Abdurakhman R. <[email protected]>
… and removed duplicated braced; Signed-off-by: Abdurakhman R. <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 552 516 -36
=========================================
- Hits 552 516 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thank you! Looks good to me. Let's see if anyone else has any comments. |
kohenkatz
approved these changes
Jul 4, 2025
3 tasks
Collaborator
|
@atlet99 thank you so much for the contribution (and apologies for the delay). Been a busy last couple of months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For fixing issue - #217