Apologies if I am missing something, but it appears the current implementation of TimestampFromV7() uses the Gregorian epoch timestamp as opposed to unix:
|
tsNanos := epochStart + time.UnixMilli(t).UTC().UnixNano()/100 |
|
// Difference in 100-nanosecond intervals between |
|
// UUID epoch (October 15, 1582) and Unix epoch (January 1, 1970). |
|
const epochStart = 122192928000000000 |
The draft states:
unix_ts_ms:
48 bit big-endian unsigned number of Unix epoch timestamp as per Section 6.1.
So shouldn't this be:
func TimestampFromV7(u UUID) (Timestamp, error) {
if u.Version() != 7 {
return 0, fmt.Errorf("uuid: %s is version %d, not version 6", u, u.Version())
}
t := 0 |
(int64(u[0]) << 40) |
(int64(u[1]) << 32) |
(int64(u[2]) << 24) |
(int64(u[3]) << 16) |
(int64(u[4]) << 8) |
int64(u[5])
return Timestamp(t), nil
}Where tests would be as straightforward as:
tests := []struct {
u UUID
want Timestamp
wanterr bool
}{
{u: Must(FromString("00000000-0000-7000-0000-000000000000")), want: Timestamp(0x000000000000)},
{u: Must(FromString("018a8fec-3ced-7164-995f-93c80cbdc575")), want: Timestamp(0x018a8fec3ced)},
{u: Must(FromString("ffffffff-ffff-7fff-ffff-ffffffffffff")), want: Timestamp(0xffffffffffff)},
}
Apologies if I am missing something, but it appears the current implementation of
TimestampFromV7()uses the Gregorian epoch timestamp as opposed to unix:uuid/uuid.go
Line 156 in 22c52c2
uuid/generator.go
Lines 37 to 39 in 22c52c2
The draft states:
So shouldn't this be:
Where tests would be as straightforward as: