Allow CallableCustom objects to be created from GDExtensions#78813
Closed
dsnopek wants to merge 1 commit intogodotengine:masterfrom
Closed
Allow CallableCustom objects to be created from GDExtensions#78813dsnopek wants to merge 1 commit intogodotengine:masterfrom
dsnopek wants to merge 1 commit intogodotengine:masterfrom
Conversation
maiself
reviewed
Jun 29, 2023
maiself
reviewed
Jun 29, 2023
dsnopek
force-pushed
the
gdextension-callable-custom
branch
from
2eb928a to
826f882
Compare
dsnopek
force-pushed
the
gdextension-callable-custom
branch
from
826f882 to
c0cbd8a
Compare
Contributor
Author
|
I just posted this draft PR godotengine/godot-cpp#1155 for godot-cpp and got it minimally working. There's still a bunch of things to finish and test in the godot-cpp PR, though, before I take them both out of draft. |
dsnopek
changed the title
Contributor
Author
|
I've now got the godot-cpp changes finished, with full test coverage! So, this is ready for review now :-) |
Contributor
Author
|
Superseded by #79005 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling
callable_mp()andcallable_mp_static()from godot-cpp was something we discussed at the last GDExtension meeting.This is an attempt at implementing the Godot side of that!
See PR godotengine/godot-cpp#1155 for the godot-cpp side
I still need to finish implementing this on the godot-cpp side, but I wanted to get this up for discussion, to see if the approached seemed OK.I've got this fully working in godot-cpp with full test coverage! So, marking this as ready for review :-)