fix: added socket closing to prevent resource leak#402
Merged
guelfey merged 1 commit intogodbus:masterfrom Nov 14, 2025
Merged
Conversation
aiburegit
commented
Mar 24, 2025
Detected by static analyzer that socket is not closed after use,
which can lead to resource leak and potential vulnerabilities such as
file descriptor exhaustion or denial of service (DoS) attacks.
Changes:
- Added `socket.Close()` call after finishing work with socket.
- Ensured that socket is closed even in case of errors while writing data.
This fix improves stability and security of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.