Do not encode message to check its validity after decoding#353
Closed
marselester wants to merge 1 commit intogodbus:masterfrom
Closed
Do not encode message to check its validity after decoding#353marselester wants to merge 1 commit intogodbus:masterfrom
marselester wants to merge 1 commit intogodbus:masterfrom
Conversation
Encoding a message with msg.EncodeTo to check whether the message is valid right after it was decoded looks redundant and incurs 13.4kB, 140 allocs per operation. If the message was corrupted, it would have failed at the decoding stage in ReadMessage.
marselester
changed the title
guelfey
reviewed
Apr 8, 2023
Member
guelfey
left a comment
guelfey
left a comment
There was a problem hiding this comment.
Fair point, just encoding everything again is definitely not needed. But skipping this would also skip the header verification which we definitely should keep
This was referenced Apr 8, 2023
Member
|
Included in #364. Thanks! |
Contributor
Author
|
Awesome 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I am not 100% sure, but encoding a message with
msg.EncodeToto check whether the message is valid right after it was decoded looks redundant and it incurs 2.9kB and 140 allocs per operation. If the message was corrupted, it would have failed earlier at the decoding stage inunixTransport.ReadMessage.