auth: Do not send UID with external auth#346
Conversation
idleroamer
force-pushed
the
authext
branch
3 times, most recently
from
ded90ae to
a0a35c0
Compare
|
Thanks. I agree that this is probably better as a default behavior, but wouldn't want to break the API for this (although probably there are not many users that use AuthExternal directly). Could you add this as a separate |
guelfey
left a comment
guelfey
left a comment
There was a problem hiding this comment.
also please check out the linter error
idleroamer
force-pushed
the
authext
branch
4 times, most recently
from
e026873 to
b3bac88
Compare
|
Somehow I tested with older godbus version, this already fixed in master as part of nevertheless I added a test-case, can't hurt |
idleroamer
force-pushed
the
authext
branch
4 times, most recently
from
4d45f30 to
f95a472
Compare
|
Thanks - could you scope the test to only be compiled on Linux? It doesn't work on FreeBSD for obvious reasons and thus would break the build there |
idleroamer
force-pushed
the
authext
branch
5 times, most recently
from
c3e67b9 to
b8baec9
Compare
|
@guelfey Thanks for the review, test is conditionalized |
conn_linux_test.go
Outdated
| @@ -0,0 +1,96 @@ | |||
| //go:build !freebsd | |||
There was a problem hiding this comment.
this is a using a Linux-only syscall - we also have other non-Linux platforms besides FreeBSD that are supported (e.g. Darwin), please adjust accordingly
There was a problem hiding this comment.
I see, adjusted accordingly, please recheck.
There was a problem hiding this comment.
you can just add linux as a build tag 😄 but I only now just noticed that you already put this in a file with a _linux suffix, which implicitly adds the corresponding build tag, so just removing the comments should be fine
There was a problem hiding this comment.
thanks for the input, speaking using sledgehammer to crack a nut :)
idleroamer
force-pushed
the
authext
branch
3 times, most recently
from
5e9aa2a to
8513e01
Compare
Due to mismatch between UID in a user-namespace and out-of-band credential acquired by server on another user-namespace refrain from sending UID with external authentication by default to keep compatibility still fallback to sending UID if it fails godbus#345
|
Thanks! |
2 participants
Due to mismatch between UID in a user-namespace and out-of-band credential acquired by server
on another user-namespace refrain from sending UID with authentication message
#345