Reduce allocs in decode function#344
Merged
guelfey merged 2 commits intogodbus:masterfrom Dec 4, 2022
Merged
Conversation
Member
|
Thanks! |
felixonmars
added a commit
to felixonmars/dbus
that referenced
this pull request
Dec 22, 2022
During refactoring in godbus#344, the newly added decodeU() function skips the dec.align() call from the original decode("u") routine. This unfortunately breaks parsing of boolean values with a lot of the following errors: ``` dbus: wire format error: invalid value for boolean ``` Adding a fixed align() call here fixes the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I tried to reduce memory allocations in the decode function to reduce GC pressure.
Apologies if I broke certain dbus protocol assumptions during refactoring, I am not very familiar with the codebase.