Pure Go FreeBSD UnixCredentials implementation#318
Closed
buglloc wants to merge 1 commit intogodbus:masterfrom
Closed
Pure Go FreeBSD UnixCredentials implementation#318buglloc wants to merge 1 commit intogodbus:masterfrom
buglloc wants to merge 1 commit intogodbus:masterfrom
Conversation
Member
|
Generally makes sense. But IMO we should have these definitions upstream in |
Member
|
Done in #332. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you to your project, it helped me a lot :)
I'm currently porting my app to the FreeBSD and CGO requirement greatly complicates this, so I would be happy to drop it.
A few thoughts on the current implementation:
ucredstruct used for socket credentials managementcmsgcredstruct. Rest of work is going inside kernel and we can't pass anything else:Therefore, it seems that nothing prevents us from determining the target buffer size, allocate it and send?