Merged
Conversation
This package does not use gopkg dep to manage dependencies. More to say, it does not have any dependencies. Even if there are some, they are fetched automatically. Remove the code that is not used to keep things simple and tidy. Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
Author
|
Related: #291 |
Contributor
Author
|
@jsouthworth @guelfey PTAL |
guelfey
reviewed
Feb 1, 2022
1. Go 1.13 is not supported since Go 1.15 was released in 2020. 2. It makes sense to test using all supported Golang versions (currently that is 1.16.x and 1.17.x). 3. It makes sense to test a beta golang release, to catch possible issues early. Signed-off-by: Kir Kolyshkin <[email protected]>
Go race detector might be useful to employ. Signed-off-by: Kir Kolyshkin <[email protected]>
I am not sure that the checking out is performed to Go module directory -- most probably not, since actions/checkout is not Go-aware. Also, older go versions required the code to be in a specific directory ($GOROOT/src/<package/name/>), but this is no longer the case. So, edit the step name to remove the misleading info. Signed-off-by: Kir Kolyshkin <[email protected]>
Merged
Rename Go to Test (same with the file name) as it won't all be Go-specific. Rename Build to test, as this is what we do (test). Job names are now "Test / test (xxx)" rather than "Go / Build (xxx)". Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
ci
branch
2 times, most recently
from
4335e1b to
e92f9ce
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of CI facelifting. Please see individual commits for details.