Conversation
jsouthworth
approved these changes
Jan 18, 2022
Member
jsouthworth
left a comment
jsouthworth
left a comment
There was a problem hiding this comment.
Some minor comments/questions. Otherwise looks good to me.
| // Emit emits the given signal on the message bus. The name parameter must be | ||
| // formatted as "interface.member", e.g., "org.freedesktop.DBus.NameLost". | ||
| func (conn *Conn) Emit(path ObjectPath, name string, values ...interface{}) error { | ||
| if !path.IsValid() { |
Member
There was a problem hiding this comment.
Out of curiosity, why are we dropping these checks?
Member
Author
There was a problem hiding this comment.
they're redundant now as they're also done in msg.IsValid()
| return InvalidMessageError("missing signature") | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Looks like a spurious empty line.
Contributor
Member
Author
There was a problem hiding this comment.
sounds good @kolyshkin, adding linting was also on my bucket list
|
|
||
| conn.sendMessageAndIfClosed(reply, nil) | ||
| if err := reply.IsValid(); err != nil { | ||
| fmt.Fprintf(os.Stderr, "dbus: dropping invalid reply to %s.%s on obj %s: %s\n", ifaceName, name, path, err) |
Member
There was a problem hiding this comment.
I'm not a huge fan of printing messages from libraries, but I don't have a better solution for this either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #295.
Logging from library code is not nice, but the best way to handle invalid reply messages IMO in a compatible way since there's not really a mechanism to make this known to application code.