Fix a data race between Conn creation and its automatic closing#291
Merged
jsouthworth merged 1 commit intogodbus:masterfrom Jan 4, 2022
Merged
Fix a data race between Conn creation and its automatic closing#291jsouthworth merged 1 commit intogodbus:masterfrom
jsouthworth merged 1 commit intogodbus:masterfrom
Conversation
`go test -race .` detects a data race when a Conn instance is automatically closed when the provided context's deadline is missed. Fix the data race by launching the corresponding goroutine only after all Conn's fields had been initialized.
Member
|
Looks good, thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go test -race .detects a data race when a Conn instance is automaticallyclosed when the provided context's deadline is missed.
Fix the data race by launching the corresponding goroutine only after all
Conn's fields had been initialized.