fix: fix dbus.Variant Store Method Bug#280
Merged
jsouthworth merged 3 commits intogodbus:masterfrom Nov 12, 2021
Merged
Conversation
when Store Method Parm is []*struct type,it work not well because in isConvertibleTo Func, it not conside Kind is ptr and elem is struct condition I add a switch case to transform type
Member
|
Can add a test case for this? |
Author
ok i will add unit test later |
switch case fallthrough key word not exec next case condition it always exec next case exp, so use isConvertibleTo call replace
when we use dbus to communicate, variant maybe lost data type info, because args was transform to bytes. so in unit test,first encode message ,then decode bytes. (it simulate one communicate).
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when Store Method Parm is []*struct type,it work not well
because in isConvertibleTo Func, it not conside Kind is ptr
and elem is struct condition
I add a switch case to transform type