Set argument of SetProperty to Variant#239
Conversation
This function fails for anything that is not a Variant with error:
No such interface “org.freedesktop.DBus.Properties” on object at path ...
Convert non-Variant into Variants.
Closes godbus#202
WhyNotHugo
force-pushed
the
setproperty-signature
branch
3 times, most recently
from
b08ac61 to
677653d
Compare
|
I'm not entirely convinced by the results here; it someone passes an I'm not sure which is the best behaviour with the current signature. |
|
But that would still be compatible to existing code - if you have a property that already is an actual Variant, you need to pass e.g. a |
|
Yeah, the main upside is that it maintains compatibility with existing code, but it's really unexpected behaviour and not a great API. Maybe it's best to merge this as-is and refine it before a major release (at which point a breaking change might be acceptable). |
3 participants
This function strictly takes a Variant, and other types will fail with error:
Closes #202