Prevent editor crash when updating styles in Site Desing component #2631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLedesma
approved these changes
Apr 9, 2025
Member
AnthonyLedesma
left a comment
AnthonyLedesma
left a comment
There was a problem hiding this comment.
Looks great. I can no longer crash the editor with these changes in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent editor crash when in patterns/media tabs in the block inserter and updating the design styles inside of the CoBlocks labs -> Site Design component.
Types of changes
Bug fix (non-breaking change which fixes an issue)
How has this been tested?
Tested this in the browser, recreating the steps outlined to crash the editor. The editor no longer crashes, however the styles will not update inside of the patterns/media tabs. This is due to changes in the editor in WordPress 6.7.2 and how the content is injected into an iframe and styles are transferred between the iframe and default editor. This will be reverted in 6.8, but will still effect users running the Gutenberg plugin.
Acceptance criteria
Reason for the PR is the prevent the editor from crashing when updating the styles under certain circumstances.
Checklist: