Skip to content

Conversation

@EvanHerman
Copy link
Contributor

@EvanHerman EvanHerman commented Jun 20, 2024

Description

The .ics parser was using fetch() to retrieve remote .ics file data. This PR uses wp_safe_remote_get() when retrieving remote .ics file data instead and removes any reference to fetch() since we do not allow local .ics files to be used.

Additional changes to the Ci/CD workflow:

  • Updated .nvmrc to 18 to use Node v18 in the workflows
  • Updated @wordpress/env to 10.1.0
  • Updated @wordpress/scripts to 28.1.0
  • Added WordPress 6.5 to the e2e test job

Screenshots

image

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Tested retrieving a remote .ics file from a Github account. (Note: The .ics file must have events in the future, or current day. If they have passed, they will not show up)

Acceptance criteria

Use wp_safe_remote_get() instead of fetch() to retrieve remote .ics file data, and ensure things still work as it does in its current state.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've added proper labels to this pull request

@EvanHerman EvanHerman added the [Type] Enhancement Something new that adds functionality label Jun 20, 2024
@EvanHerman EvanHerman added this to the Next Release milestone Jun 20, 2024
@EvanHerman EvanHerman self-assigned this Jun 20, 2024
@EvanHerman EvanHerman modified the milestones: Next Release, 3.1.12 Jun 24, 2024
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@EvanHerman EvanHerman merged commit c75d400 into master Jun 24, 2024
@EvanHerman EvanHerman deleted the event-bug-fix branch June 24, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement Something new that adds functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants