[Urgent] Performance: don't subscribe all blocks to selected block#2575
Merged
AnthonyLedesma merged 1 commit intogodaddy-wordpress:masterfrom Oct 26, 2023
Merged
Conversation
AnthonyLedesma
approved these changes
Oct 24, 2023
Member
AnthonyLedesma
left a comment
There was a problem hiding this comment.
Excellent find. Thank you so much for looking into this issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Coblocks extends all blocks (through the
editor.BlockListBlockfilter) with awithSelectHoC, subscribing all blocks to the currently selected block. This means that on typing, the selected block updates, and all blocks on the page re-render because they are all subscribed to changes to the selected block.I went through all functions in
addAllEditorPropsto whichpropsis being passed to, but none of them seem to be usingprops.selected, so it looks like this subscription can be removed without further changes.Screenshots
Types of changes
Use the React Dev Tools and enable highlight on re-render. Type in a block and watch all blocks re-render.
How has this been tested?
Acceptance criteria
Checklist: