Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apparently, the V1 block.json was being loaded for the Masonry block instead of the v2 that it should be using. We keep some old code around for backward compat and conditionally load that old block. The new logic around
globbing
the paths and registering all blocks did not account for this. Added some new logic to ensure we do not register legacy blocks.New tests added to catch if this issue ever reoccurs.
Screenshots
Types of changes
Fixed logic around block registration, fixed block.json 'viewScript' property, registered the script to enqueue later, and added new e2e tests to catch if this ever happens again.
How has this been tested?
E2E and manually tested.
Acceptance criteria
Lightbox should be working with Masonry block.
Checklist: