Skip to content

Import fails when picture choice questions have empty/missing image data #3070

@brianhogg

Description

@brianhogg

Reproduction Steps

  1. Create a course with a quiz containing a picture_choice question
  2. Add image-type choices but leave the image data empty or remove the images before export
  3. Export the course as JSON
  4. Attempt to import the JSON file on another site

Expected Behavior

Course import succeeds and inserts empty picture choice question

Actual Behavior

Fatal error

Error Messages / Logs

PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in 
/wp-content/plugins/lifterlms/includes/class-llms-generator-courses.php:632

Stack trace:
#0 class-llms-generator-courses.php(454): LLMS_Generator_Courses->maybe_sideload_choice_image()
#1 class-llms-generator-courses.php(384): LLMS_Generator_Courses->create_question()
#2 class-llms-generator-courses.php(333): LLMS_Generator_Courses->create_quiz()
#3 class-llms-generator-courses.php(522): LLMS_Generator_Courses->create_lesson()
#4 class-llms-generator-courses.php(269): LLMS_Generator_Courses->create_section()
#5 class-llms-generator-courses.php(163): LLMS_Generator_Courses->create_course()
#6 class-llms-generator-courses.php(132): LLMS_Generator_Courses->generate_courses()
#7 class.llms.generator.php(138): LLMS_Generator_Courses->generate_course()
#8 class.llms.admin.import.php(228): LLMS_Generator->generate()
#9 class.llms.admin.import.php(300): LLMS_Admin_Import->handle_generation()

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Review in Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions