fix(test): stop sharing http.DefaultTransport across parallel tests#85
Merged
Conversation
httptest.Server.Close calls DefaultTransport.CloseIdleConnections as cleanup, so any parallel test using http.Get / http.DefaultClient can have its idle connection severed by an unrelated test's server teardown — surfacing as 'transport connection broken: CloseIdleConnections called' (seen on main CI in mw's HSTS test). Every test now uses its own server's Client(), whose transport no other test can touch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httptest.Server.Closecallshttp.DefaultTransport.CloseIdleConnections()as cleanup. All test files uset.Parallel()+http.Get/http.Post/http.DefaultClient(shared DefaultTransport), so one test's server teardown can sever an idle connection another test is about to reuse — thetransport connection broken: CloseIdleConnections calledflake that failed CI on main (mw HSTS test).Mechanical fix across 20 test files: every request now goes through its own
server.Client(), whose transport no other test can touch.vtalready used dedicated transports and is untouched.Testing
go vet ./...cleango test -count=3 -parallel 16 ./...— zero failures across 3 stress runs