fix(on): split panic by nil / top-level / closure (#36)#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36.
Summary
on.*previously panicked with a single lumped message ("got a closure, top-level function, or nil") regardless of which mistake the caller actually made.notMethodPanic(event, fn)inon/on.gothat usesreflect+runtime.FuncForPCto classify the bad input asnil,a closure, ora top-level function; both panic sites (theeventfast path and the optionedrenderpath) route through it..funcsegment in the runtime function name;-fm-suffixed bound methods are already handled upstream byspec.MethodName.Test plan
go test -race ./...on.Click(event fast path) and a closure viaon.Key(render path).