fix(vt): isolate http.Transport per Client to stop parallel-test flakes#42
Merged
Conversation
vt.Client constructed http.Client values with Transport unset, so they shared http.DefaultTransport's idle pool with every other parallel test. One test's defer server.Close() could invalidate idle keep-alives held by another, surfacing "http: CloseIdleConnections called" (#40). Give each httpc/sseClient its own &http.Transport{}. Add tests that swap http.DefaultTransport with a recording wrapper and assert NewClient / Fork / SSE never route through it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestUpdate_flipsBoolSignalSurfacingInSSEfrom sharedhttp.DefaultTransportidle pool across parallel tests.vt.NewClient,vt.Client.Fork, andvt.Client.SSEnow each construct theirhttp.ClientwithTransport: &http.Transport{}so connection pools are isolated.vt/vt_isolation_test.go— three tests swaphttp.DefaultTransportwith a recording wrapper and assert each constructor never routes through it.Test plan
go test -race -count=1 ./...clean./ci-check.shclean: gofmt, vet, golangci-lint, govulncheck, build (incl. 11 examples), tests, alloc gates