feat: WithVerboseErrors to surface real panic messages in dev#115
Merged
Conversation
joaomdsg
force-pushed
the
fix/verbose-errors
branch
from
June 10, 2026 19:02
c78947e to
0f5e7d7
Compare
A recovered action panic shows the browser a generic "Something went wrong". The typed error already reaches a custom WithActionErrorHandler and the server log, but the default client surface masks the real message — fine for prod (no info disclosure), needlessly opaque in development. WithVerboseErrors() opts the default client notification into showing the real error message. Off by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critic panel finding #6 (major; raised 3×) — scope corrected after reading the code.
The fix the critic described ("type-assert the recovered panic value") is already present:
action.go:227-230preservespanic(err)as a typed error for a customWithActionErrorHandler, and the real message is logged server-side (:224). The only remaining gap is the default client surface, which masks panics as generic "Something went wrong" — correct for prod (no info disclosure), needlessly opaque in dev.Change
WithVerboseErrors(): opt the default client notification into showing the real panic error message. Off by default.Tests
boom-detail-42) does NOT reach the client; "Something went wrong" doesFull
ci-check.shgreen.