feat: WithMaxSessions to bound the live session map#113
Merged
Conversation
A cookieless crawler could mint unbounded sessions and OOM the pod — the session map had no cap, asymmetric with the existing WithMaxContexts. Add WithMaxSessions(n): once the cap is met, a request that would mint or adopt a NEW session is rejected with 503 (the cap check is fused with the map insert under sessionsMu, so concurrent mints can't both slip past). A client that already holds a live session is never refused. Default 0 (no cap).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critic panel finding #10 (minor; perf + security). The session map had no cap — asymmetric with the existing
WithMaxContexts— so a cookieless crawler could mint unbounded sessions and OOM the pod.Change
WithMaxSessions(n): once the cap is met, a request that would mint or adopt a new session is rejected with 503. A client that already holds a live session is never refused. The cap check is fused with the map insert undersessionsMu(TOCTOU-safe, mirroringtryRegisterCtx). Default 0 = no cap.Tests
Full
ci-check.shgreen.