Conversation
…mand Add glob pattern matching (*, ?, [...]) for the -s/--stackName option in the cdk subcommand. Patterns without glob characters are matched exactly as before. Glob patterns that match nothing are not treated as errors, while exact names not found still produce errors. Refactor CdkAction to separate concerns: - CdkStackSelector: pattern/interactive stack selection (pure logic) - CdkStackResolver: region resolution, selection, AWS existence check - CdkAction: orchestration only (synth, parse, resolve, confirm, delete) - IStackExistenceChecker: interface for AWS stack existence verification Add e2e test (cdk_glob) with top-level stacks and Stage to verify glob-based partial deletion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*,?,[...]) for the-s/--stackNameoption in thecdksubcommandCdkActioninto focused components:CdkStackSelector(pattern matching),CdkStackResolver(region resolution + AWS existence check),IStackExistenceChecker(DI interface), keepingCdkActionas a pure orchestratorcdk_globe2e test with top-level stacks and Stage-nested stacks to verify glob-based partial deletionGlob matching behavior
*,?,[) are matched usingpath.Match